Someone ask to see my code and point out errors?

Good day!

I think, anyway, any programmer in the process of professional growth is faced with the need to hear expert opinion, maybe some advice to improve your project.

In fact, as people understand that healthy criticism is one of the most effective ways to learn your mistakes, I try not avoided, and sometimes I did miss her.

Alone it is difficult to objectively assess the shortcomings of their own creations, so I would like to know the way to find such people willing to understand someone else's code and give helpful tips, at least for the satisfaction of the need to convey the experience (I'm not talking about "knowing" that a month has worked in the specialty and now impose their invaluable experience right and left).

What would you recommend?


For information, I just recently started drinking (his first!) the project on github, a PHP class for generating captcha. I know that sounds so cheesy, but had nothing else to think of besides. I've got a week to restore gloss, so to collect info on grains, randomly of Google documents and flipping through Habr - not the best idea =)
August 19th 19 at 23:10
6 answers
August 19th 19 at 23:12
Describe what is not in the code, from the point of view of gloss.
Broken psr-1 and psr-2, psr missing-4.
In the code, spotted dog @, which is not really needed there. It could be forgiven if at least on was a test of false (like suddenly php-gd is missing), but alas.
On passing variable by reference &. Why is it? It is not an external function, $this->_image hand, the parameter is not needed at all, especially the link.
Deceptive method getImage. It would be nice if it returns a binary string from the image, not the resource. A resource to Shine does not need.
Why Shine $config everything?
There is no support for composer (composer.json and .gitattributes).
This specifically, thank you. - ruthie_Stracke commented on August 19th 19 at 23:15
August 19th 19 at 23:14
Sometimes criticism is not a criticism, just not the ability to perceive someone else's code that turns out to be an attempt to teach people how to write, how convenient from a particular point of view, not as a right.
Yes, I too little know about it, you will be able to distinguish.

There is more often triggered the opposite effect: an experienced person tells how to do it, and the novice thinks knows nothing and advises incorrectly, and generally he is the smartest xD

And in the end makes their own way. - ruthie_Stracke commented on August 19th 19 at 23:17
August 19th 19 at 23:16
Looked, code - normally decorated, but for captcha:
1. check captcha is successful in any case
2. similar process when writing characters the same way (for example, l and 1 are one and the same, etc.)
3. use of dynamic distortion, not static (as it is now)
4. try to generate words-neologisms (1-2 consonants and a vowel), use the numbers only at the beginning or end of a word it will be easier to enter for the user.
5. one wrong character in any place - is not considered a mistake (a typo)
The food in the refrigerator to end.

Seriously, I need to provide a project on github that demonstrates my skills as a PHP development and also work with the version control system. - ruthie_Stracke commented on August 19th 19 at 23:19
Thanks, put in "todo" - ruthie_Stracke commented on August 19th 19 at 23:22
August 19th 19 at 23:18
1. To write code according to PSR
2. Use the code of the popular libraries in their task to see what was happening. After that, it becomes clear how you can improve your code immediately or the next day ;)
Search for someone that he appreciated the code in your case is not the right lesson. First, let a "verifier" proves that writes cool and understandable code :)
In General, I do. But still feel that we need to look the part. - ruthie_Stracke commented on August 19th 19 at 23:21
August 19th 19 at 23:20
Question briefly sounds
How to consult Siniora just

It does not happen
Look for a job, where can take Trani
I'm doing this in order for me to work in, and you here is a write... ) - ruthie_Stracke commented on August 19th 19 at 23:23
: in order to be accepted, you need to write more and to rewrite, not hope for you someone will do it - ruthie_Stracke commented on August 19th 19 at 23:26
August 19th 19 at 23:22
write useful OpenSRS
What in your understanding is "useful" opencores? - ruthie_Stracke commented on August 19th 19 at 23:25
obviously their issue is that the used by people - ruthie_Stracke commented on August 19th 19 at 23:28
: and who said that my cannot be used? Him a couple of days old, improve algorithms, add features - and to the masses ;) - ruthie_Stracke commented on August 19th 19 at 23:31
: well then, where did you get the question ? the one who will use it and will revise your code - ruthie_Stracke commented on August 19th 19 at 23:34

Find more questions by tags CareerOpen SourcePHPProgramming