Questions tagged [Code review] (36)

3
answers

How do you like the layout of the restaurant?

This is my first site layout (done for myself, my imaginary restaurant). The idea was to restaurant for bikers, where they can enjoy food and at the same time to fix your bike. I would like to hear objective criticism and what mistakes in the design I have. Link to the png and psd file Thank you)
francisco_Hirthe asked April 19th 20 at 11:57
0
answer

What is the problem in the slider?

Please help to understand what the problem is slider? Slider wants to do without special programs https://codepen.io/landfix/pen/PoqvrEo
mikel_Dickins asked April 16th 20 at 11:00
1
answer

Why this code is not working correctly?

Write a ray casting on the JavaScript wrote code like this but when the beam comes to a certain point and it stuck. <!DOCTYPE html> <html> the <head> <title>Game</title> </head> the <body> <canvas id="canvas" width="320" height="320"></canvas> <style type="text/css"&g...
tyshawn asked April 8th 20 at 18:18
2
answers

How to know that the incoming parameter in the function, someone else's code?

In function yearsDiff(dt) @dt - what is the value? // @passportDate - issue date // @dudeDate - date of birth dude function checkPassportDate(passportDate, dudeDate) { var dob = new Date(dudeDate.replace(/(\d{2}).(\d{2}).(\d{4})/, "$3-$2-$1")); var pssprtDate = new Date(passportDate.replace(/(\d{2}).(\d{2}).(\d{4})/, "$3-...
jackie34 asked April 8th 20 at 02:42
1
answer

How to improve code review on GitHub?

Is there a repository. In my case, a project on electron+typescript, but I think it's not very important. Every Pull Request is run Linter code. Somewhere out in the actions in the text view displays a list of found problems. It would be great if Linter is not just testing the code and output in the "console" error, but w...
Easton asked April 3rd 20 at 17:57
2
answers

Which design is preferable?

Found a couple of solutions to this task: 1. To console the values of three integers 2. To choose the greatest of three numbers using if 3. Bring to the console 4. Compare parity with Switch 5. To check the size < 100 using quick test I'm sorry that as many as 5 pieces of code, but I need to figure out how to arrange th...
Kiara.Harber asked April 3rd 20 at 17:33
1
answer

Code review. What can be improved?

Well, there's that thread of spaghetti code is? I just don't understand what am I doing wrong, my code seems to work fine, I just wanted to show a random number and erased, so to speak practice. Just answer me pliz, this bydlokod or not?using System; using System.Collections.Generic; using System.Linq; using System.Text; us...
willis.Stiedemann asked April 3rd 20 at 16:50
5
answers

This code is highly terrible)?

I was haunted by what I write curve code, it works its job, but I like it uncomfortable to give such a project to the customer. Please see the code of more experienced colleagues, and point out my mistakes) For the past two weeks)<?php include "bitrix.php"; include "function.php"; require_once '../src/db.php'; use Aura...
ezra_Koss asked April 2nd 20 at 16:42
3
answers

OOP exercise (analysis of the object) on a free theme "Cooking soup" that you say?

Like most mastering OOP I'm having difficulties when you need to apply all the theory that I draw from books and the Internet, in theory it's pretty simple but when it comes to practical application on live projects there is some strange stupor. To the stupor gradually eliminate decided to practice it in the "object analysi...
nettie asked April 1st 20 at 17:50
1
answer

How the decision is consistent with the statement of work(React)? Is there any gross errors?

Dear experts React, I would be very grateful if someone will look like it was made to do a test. The timescale is quite tight and I worked all the time in vue js + vuex. As shown it is very different from the react + redux. Understand what to modify there's a lot of need, it is important to point out blunders. The text of t...
Alisa25 asked April 1st 20 at 16:55